feat: write_be_fields refactor: make VDR/rVDR pure isbits values#53
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
Benchmark Results (Julia v1)Time benchmarks
Memory benchmarks
|
refactor: make VDR/rVDR pure isbits values Drop the buffer (and gdr for rVDR) context fields from the VDR structs; accessors that need file context (record_sizes, num_record_dims, read_vvrs, variable_compression) now take the dataset. Records become plain file-field values — consistent with the schema direction for write support — and VDR construction no longer heap-allocates: ds["BGSEc"] is down to 3 allocations. VDR show no longer prints dims (needed buffer context); the variable summary line already shows them. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Beforerr
force-pushed
the
push-mlpouynttxvx
branch
from
fd04ee9 to
66457dc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop the buffer (and gdr for rVDR) context fields from the VDR structs;
accessors that need file context (record_sizes, num_record_dims,
read_vvrs, variable_compression) now take the dataset.