refactor: R{FST}(buffer, offset) record constructor style#52
Merged
Conversation
Move the field-size type from a trailing positional argument into the type parameter for the records that already carry it (CDR, GDR, VDR, rVDR, VXR, ADR). CPR/CCR/CVVR keep the positional form: their structs are not parameterized by FST — there it is a parsing parameter, not type identity. No behavior change; trim-equivalent (where-param either way). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
Benchmark Results (Julia v1)Time benchmarks
Memory benchmarks
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the field-size type from a trailing positional argument into the
type parameter for the records that already carry it (CDR, GDR, VDR,
rVDR, VXR, ADR). CPR/CCR/CVVR keep the positional form: their structs
are not parameterized by FST — there it is a parsing parameter, not
type identity. No behavior change; trim-equivalent (where-param either
way).