feat: add close(::CDFDataset)#49
Merged
Merged
Conversation
Contributor
Benchmark Results (Julia v1)Time benchmarks
Memory benchmarks
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was no way to release the mmap (which locks the file on Windows) before GC. close finalizes the backing map; compressed files already live in memory, and their original mmap is now unmapped eagerly right after decompression instead of lingering until GC. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Beforerr
force-pushed
the
push-wkxuwqxkykwy
branch
from
b7b13f1 to
e027e09
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was no way to release the mmap (which locks the file on Windows)
before GC. close finalizes the backing map; compressed files already
live in memory, and their original mmap is now unmapped eagerly right
after decompression instead of lingering until GC.
Co-Authored-By: Claude Fable 5 noreply@anthropic.com