fix: RLE decompression for compressed variable records#47
Merged
Conversation
decompress_bytes! had an empty RLE branch: RLE-compressed CVVRs silently left dest uninitialized. Route RLE through _rle_decompress (output size is known from the read request) and throw ArgumentError for unsupported codecs (Huffman/AHUFF) instead of @Assert. No CDF writer in the ecosystem emits variable-level RLE (cdflib/pycdf fixtures are gzip-only, which is how this went untested), so tests build CVVRs by hand. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
Benchmark Results (Julia v1)Time benchmarks
Memory benchmarks
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
decompress_bytes! had an empty RLE branch: RLE-compressed CVVRs silently
left dest uninitialized. Route RLE through _rle_decompress (output size
is known from the read request) and throw ArgumentError for unsupported
codecs (Huffman/AHUFF) instead of @Assert.
No CDF writer in the ecosystem emits variable-level RLE (cdflib/pycdf
fixtures are gzip-only, which is how this went untested), so tests build
CVVRs by hand.
Co-Authored-By: Claude Fable 5 noreply@anthropic.com