Update version check for Enzyme support#135
Open
wsmoses wants to merge 5 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #135 +/- ##
==========================================
- Coverage 92.36% 89.15% -3.21%
==========================================
Files 8 8
Lines 786 747 -39
==========================================
- Hits 726 666 -60
- Misses 60 81 +21 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
CI failure seems Enzyme-related? |
Member
|
Any update on this? |
stevengj
reviewed
Jun 24, 2026
|
|
||
| @inline function guaranteed_nonactive(::Type{T}) where T | ||
| rt = Enzyme.Compiler.active_reg_inner(T, (), nothing) | ||
| rt = Enzyme.Compiler.active_reg_nothrow(T) |
Member
There was a problem hiding this comment.
This is giving a MethodError in CI:
Enzyme: Error During Test at /Users/runner/work/QuadGK.jl/QuadGK.jl/test/runtests.jl:475
Test threw exception
Expression: (0.3 * cos(0.3) - sin(0.3)) / (0.3 * 0.3) ≈ ((Enzyme.autodiff(Reverse, f3_count, Active(0.3)))[1])[1]
MethodError: no method matching active_reg_nothrow(::Type{QuadGKEnzymeExt.ClosureVector{QuadGK.Counter{var"#121#124"{Float64}}}})
Closest candidates are:
active_reg_nothrow(::Type{T}, ::Val{world}) where {T, world}
@ Enzyme none:0
Stacktrace:
[1] guaranteed_nonactive(#unused#::Type{QuadGKEnzymeExt.ClosureVector{QuadGK.Counter{var"#121#124"{Float64}}}})
@ QuadGKEnzymeExt ~/work/QuadGK.jl/QuadGK.jl/ext/QuadGKEnzymeExt.jl:66
[2] recursive_add
@ ~/.julia/packages/Enzyme/TiboG/src/compiler.jl:6704 [inlined]
[3] *(a::Float64, b::QuadGKEnzymeExt.ClosureVector{QuadGK.Counter{var"#121#124"{Float64}}})
@ QuadGKEnzymeExt ~/work/QuadGK.jl/QuadGK.jl/ext/QuadGKEnzymeExt.jl:80
[4] *(a::QuadGKEnzymeExt.ClosureVector{QuadGK.Counter{var"#121#124"{Float64}}}, b::Float64)
@ QuadGKEnzymeExt ~/work/QuadGK.jl/QuadGK.jl/ext/QuadGKEnzymeExt.jl:84
[5] evalrule(f::QuadGKEnzymeExt.var"#11#15"{Active{Tuple{Float64, Float64}}, Active{QuadGK.Counter{var"#121#124"{Float64}}}, Do we need to require a newer version of Enzyme?
Contributor
Author
There was a problem hiding this comment.
Member
There was a problem hiding this comment.
if we need to bump the minimum version to 1.10 that is fine. But can't we just test the extension on 1.10+?
stevengj
reviewed
Jun 25, 2026
| # Extension package only supported in 1.9+, but Enzyme doesn't yet support Julia 1.12 | ||
| @static if v"1.9" <= VERSION < v"1.12" | ||
| # Extension package only supported in 1.9+ | ||
| @static if v"1.9" <= VERSION |
Member
There was a problem hiding this comment.
Should this be bumped?
Suggested change
| @static if v"1.9" <= VERSION | |
| @static if v"1.10" <= VERSION |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.