escape should work with AbstractString.#60
Merged
ViralBShah merged 1 commit intoJun 19, 2026
Conversation
MarkNahabedian
added a commit
to MarkNahabedian/AnotherParser.jl
that referenced
this pull request
May 14, 2026
Collaborator
|
Addressed in #54 |
mathieu17g
added a commit
that referenced
this pull request
Jun 20, 2026
CHANGELOG.md (new): itemises 0.3.9 — #56 (CDATA delimiter fix), #59 (next!/prev!), #60 (escape AbstractString), #64 (OrderedCollections v2 compat); notes the move to JuliaData. Changelog starts at 0.3.9 (earlier history via releases/tags). test/runtests.jl: regression tests for the two fixes that merged without their own coverage — prev() across a CDATA section (#56) and escape(::SubString) (#60). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
mathieu17g
added a commit
that referenced
this pull request
Jun 20, 2026
CHANGELOG.md (new): itemises 0.3.9 — #56 (CDATA delimiter fix), #59 (next!/prev!), #60 (escape AbstractString), #64 (OrderedCollections v2 compat); notes the move to JuliaData. Changelog starts at 0.3.9 (earlier history via releases/tags). test/runtests.jl: regression tests for the two fixes that merged without their own coverage — prev() across a CDATA section (#56) and escape(::SubString) (#60).
mathieu17g
added a commit
that referenced
this pull request
Jun 24, 2026
Regression tests for already-shipped fixes, plus one clear-error addition: - BOM decode (read path): UTF-16 LE/BE + UTF-8 BOM each decode to <a/> (guards _normalize_bom). - escape(SubString): #60 — escape was String-specialized; the AbstractString fix is now pinned. - UTF-16 without a BOM: _normalize_bom now raises "UTF-16 without a BOM is not well-formed (XML 1.0 §4.3.3)" when no BOM matched but a NUL byte sits in the first two positions. Previously :structural still rejected it, but with a cryptic "invalid element name" (interleaved NULs derail tokenization); this names the real cause. Two comparisons, not an O(n) isvalid(String) scan. The UTF-16-no-BOM tests assert the clear §4.3.3 message specifically — a bare @test_throws would false-pass since :structural already throws. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
XML.escapedid not supportSubStringbecause it was specialized onStringintead ofAbstractString.