Handle TCE nsig branches with plain if guards#645
Merged
Conversation
Derive nsig control parameters for TCE player functions whose split branch is guarded by a normal if block instead of a labeled block. Player 9fc68080, reported in issue JuanBindez#642, exposes the nsig transform through a multi-purpose function whose table lookup may include whitespace after the XOR operator. This change lets the XOR branch extractor match those lookups, avoids property-method false positives when locating function bodies, and runs the extractor before returning from the fast var=[func] detection path. Validated against player_ias_tce files for 0980151a and 9fc68080, plus IAS sanity checks for 57f5d44f and 16ef956e. Signed-off-by: Justin "Muggwomp" Corey <justincorey@mindgarden.cc> Assisted-by: Codex:5.5 [OpenAI] Signed-off-by: Justin "Muggwomp" Corey <justincorey@mindgarden.cc>
JuanBindez
added a commit
that referenced
this pull request
Jun 3, 2026
Signed-off-by: Juan Bindez <juanbindez780@gmail.com>
JuanBindez
added a commit
that referenced
this pull request
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Derive nsig control parameters for TCE player functions whose split branch is guarded by a normal if block instead of a labeled block.
Player 9fc68080, reported in issue #642, exposes the nsig transform through a multi-purpose function whose table lookup may include whitespace after the XOR operator. This change lets the XOR branch extractor match those lookups, avoids property-method false positives when locating function bodies, and runs the extractor before returning from the fast var=[func] detection path.
Validated against player_ias_tce files for 0980151a and 9fc68080, plus IAS sanity checks for 57f5d44f and 16ef956e.
Assisted-by: Codex:5.5 [OpenAI]