Repository navigation
Accept native Companion chat bridge without changing welcomes - #1
Draft
JosephJagger wants to merge 1 commit into
Draft
JosephJagger wants to merge 1 commit into
JosephJagger wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HomeDouyinCollector 0.3.0 can deliver genuine native Companion chat, but the panel rejects its companion-memory-bridge source as an unsupported native action. With one entry and one chat packet, diagnostics report two packets, one entry, zero chats and one rejection. This change accepts the native chat contract and displays the chat while preserving its provenance.
Acceptance is restricted to Type 1, Companion process name, CollectorSource=companion-memory-bridge, CollectorTransport=native-publish-message and NativeMethod=WebcastChatMessage. Existing identity/freshness checks remain. Bridge entries are rejected; welcome eligibility still requires the existing companion-log entry source. No voice coordinator, welcome timing or production configuration changes are included.
Validation: 14 focused live-interactions tests pass, including display without executing markup or sending a welcome, and rejection of wrong transport/method/entry/stale frames. Web TypeScript check passes. An offline comparison using the actual captured chat packet reproduces old-parser native rejection and confirms new-parser chat acceptance with welcome eligibility false. The saved packet was not replayed into the deployed page; no real message text or IDs are committed.
Deployment note: the user's deployed welcome behavior is newer than this main checkout. Apply this small parser/test/docs change to the actual deployment branch; do not replace the deployed app wholesale with this older main snapshot. The current live page has not been updated and real post-deployment display still needs verification.