Modularize WPF/Avalonia Main, Transition, and Modifications windows with section UserControls#65
Modularize WPF/Avalonia Main, Transition, and Modifications windows with section UserControls#65Copilot wants to merge 4 commits into
Conversation
Agent-Logs-Url: https://github.com/JohnnyJF10/TgaBuilder/sessions/9fbe2778-c2d9-4b31-981f-2f732f4d0e3c Co-authored-by: JohnnyJF10 <83164789+JohnnyJF10@users.noreply.github.com>
|
@copilot Now, modularize the MainWindow, TransitionWindow, ModificationsWindow in WPF and Avalonia UI version, by introducing new UserControls. In the MainWindow, create UserControls for the tabs (nothing else for the moment) and name them like MainWindowFormatUserControl for format tab, others the same way, place them in the View Folder as well. For the TransitionWindow, ModificationsWindow , make UserControls for each expander child, then give names like TransitionWindowPivotUserControl . |
Agent-Logs-Url: https://github.com/JohnnyJF10/TgaBuilder/sessions/5dff26a4-edd7-487c-8012-a8d8eb7610b4 Co-authored-by: JohnnyJF10 <83164789+JohnnyJF10@users.noreply.github.com>
Implemented in commit I modularized both WPF and Avalonia as requested:
I also updated references in the parent windows and validated with builds/tests. Screenshot: I can’t capture runtime desktop UI screenshots in this headless CI runner, but the structural UI split is fully in place in the committed XAML/UserControl files. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
d: color attributes for TextFillColor-based bindings in key windows|
@copilot You missed the resources on the new user controls, so they cannot resolve styles and converters. For each new user control, copy the Window.Resources of the window it belongs to, turn it to UserControl.Resources and for each remove the entries which are not required, but keep those which are required |
Agent-Logs-Url: https://github.com/JohnnyJF10/TgaBuilder/sessions/3a7b5e9c-462f-4a0c-8f1d-6be427688f90 Co-authored-by: JohnnyJF10 <83164789+JohnnyJF10@users.noreply.github.com>
Fixed in commit I added Screenshot: unable to capture runtime desktop UI in this headless runner environment; validation was done via successful build/test after the resource fixes. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
@copilot Let's continue. We need to correct IntelliSense for all new UserControls. In Avalonia UI version, use x:DataType="viewmodel:TransitionViewModel" (or similar for other View Models) in the window definitions. Try to remove mc:Ignorable="d" where possible. In WPF version, use d:DataContext="{d:DesignInstance Type=viewmodel:TransitionViewModel, IsDesignTimeCreatable=False}" or similar |
Agent-Logs-Url: https://github.com/JohnnyJF10/TgaBuilder/sessions/39c1baf3-63c2-449d-8915-78210932d2de Co-authored-by: JohnnyJF10 <83164789+JohnnyJF10@users.noreply.github.com>
Implemented in commit I updated all newly extracted UserControls for IntelliSense/design-time typing:
Screenshot: Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
This PR modularizes the WPF and Avalonia UI window XAML structure by extracting large in-window sections into dedicated
UserControls, while preserving existing behavior and bindings.Scope
TgaBuilderWpfUi/View/MainWindow.xamlTgaBuilderWpfUi/View/TransitionWindow.xamlTgaBuilderWpfUi/View/ModificationsWindow.xamlTgaBuilderAvaloniaUi/View/MainWindow.axamlTgaBuilderAvaloniaUi/View/TransitionWindow.axamlTgaBuilderAvaloniaUi/View/ModificationsWindow.axamlViewin both WPF and Avalonia:What changed
MainWindow...UserControl(including format tab controls).TransitionWindowPivotUserControl.<local:...UserControl />.Result
Validation
dotnet build TgaBuilderAvaloniaUi/TgaBuilderAvaloniaUi.csprojdotnet build TgaBuilderWpfUi/TgaBuilderWpfUi.csproj -p:EnableWindowsTargeting=truedotnet test -p:EnableWindowsTargeting=true