[codex] Fix packaged markdown text selection#88
Merged
Conversation
nerocui
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the packaged-build markdown/code-viewer selection crash and first-drag flash by keeping the preview renderer stable during queued view-model refreshes and hardening the markdown selection overlay lifecycle.
Root Cause
In packaged x86 builds, the first pointer interaction could trigger a queued preview refresh that replaced the markdown renderer while it owned pointer capture. That dropped capture mid-drag and, in the crash path, caused overlay children to be added during WinUI measure/arrange.
Changes
Validation
dotnet test MarkdownRenderer\MarkdownRenderer.Tests\MarkdownRenderer.Tests.csproj -c Release -p:Platform=x64 --no-restoredotnet test JitHub.WinUI.Tests\JitHub.WinUI.Tests.csproj -c Release -p:Platform=x64dotnet build JitHub.WinUI\JitHub.WinUI.csproj -c Release -p:Platform=x86 -p:GenerateAppxPackageOnBuild=false --no-restore