[codex] Fix repo manage crash#87
Merged
Merged
Conversation
zhuowcui
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the Manage Repository crash reported during Microsoft Store certification.
Root cause
The Manage Repository page materialized selectable repository templates that applied the shared
Containerstyle toGridelements. That style targetsBorder, so WinUI threw a XAML parse exception when the template loaded after clicking the gear button. In the Store crash report this surfaced as a0xc000027bfail-fast inMicrosoft.UI.Xaml.dll.Changes
Borderfor selectable repository templates that apply theContainerstyle.RepoManagePageto the newer DI-backedRepoManagePageViewModelflow.Containerstyle to non-Borderelements.Validation
dotnet build .\JitHub.WinUI\JitHub.WinUI.csproj -c Release -p:PublishAot=false -p:PublishTrimmed=false--page=home, invokedRepoSideBarManage, verified “Manage repositories” appeared and the process stayed alive.dotnet test .\JitHub.WinUI.Tests\JitHub.WinUI.Tests.csproj -c Releasepassed: 99 tests.powershell -NoProfile -ExecutionPolicy Bypass -File .\eng\Build-JitHubWinUIStorePackage.ps1 -ProjectPath .\JitHub.WinUI\JitHub.WinUI.csproj -OutputDirectory .\artifacts\store-smoke -BundlePlatforms x64completed and produced the bundled.msixupload.