[codex] Fix release markdown rendering#86
Merged
Conversation
zhuowcui
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes release-mode markdown previews rendering only the first visible block by avoiding an unconditional
CanvasTextLayout.LineMetricsread during decoration drawing.Root Cause
In Release/AOT, the WinRT projection can throw
NotSupportedExceptionwhile marshallingCanvasLineMetrics. The renderer fetched line metrics unconditionally in the inline decoration pass, even when the block did not need underline or strikethrough decoration. That exception aborted the tile paint after the first block, leaving headings and non-virtualized overlay controls visible while the rest of the markdown body was blank.Changes
Validation
dotnet test MarkdownRenderer\MarkdownRenderer.Tests\MarkdownRenderer.Tests.csproj -c Debug -p:Platform=x64 --nologopassed: 292 tests.dotnet build JitHub.WinUI\JitHub.WinUI.csproj -c Release -p:Platform=x64 --nologosucceeded.dotnet publish JitHub.WinUI\JitHub.WinUI.csproj -c Release -p:Platform=x64 --no-restore --nologosucceeded with existing trim/AOT warnings.JitHubApp/JitHubV2repo code page and renderedREADME.mdin Rich mode with multiple markdown blocks visible.