Skip to content

[codex] Integrate MarkdownRenderer in JitHub#85

Merged
zhuowcui merged 1 commit into
mainfrom
codex/markdown-renderer-jithub
May 17, 2026
Merged

[codex] Integrate MarkdownRenderer in JitHub#85
zhuowcui merged 1 commit into
mainfrom
codex/markdown-renderer-jithub

Conversation

@Xueyang-Song

Copy link
Copy Markdown
Collaborator

Summary

  • replace JitHub markdown surfaces with the in-repo MarkdownRenderer wrapper using GFM, TextMate highlighting, app theming, code copy, selection, links, and image resolution
  • add authenticated/private GitHub markdown image resolution and renderer image resolver plumbing
  • restore and polish incremental loading for activities, issues, PRs, and commits with subtle list indicators
  • fix search box focus behavior with app-wide Ctrl+K, Esc dismissal, keycap badge, focused ring, and UI automation coverage

Why

The old MarkdownTextBlock path could not support the production renderer behavior consistently across previews, comments, and forms. The integration also surfaced regressions around theme colors, layout, SVG badges, code-copy controls, incremental loading, and titlebar search focus that this PR closes out together.

Validation

  • dotnet build JitHub.WinUI\JitHub.WinUI.csproj -c Debug -p:Platform=x64 --no-restore
  • dotnet test JitHub.WinUI.Tests\JitHub.WinUI.Tests.csproj -c Debug -p:Platform=x64 --no-restore
  • dotnet test MarkdownRenderer\MarkdownRenderer.Tests\MarkdownRenderer.Tests.csproj -c Debug -p:Platform=x64 --no-restore
  • dotnet run --project JitHub.WinUI.Automation\JitHub.WinUI.Automation.csproj -c Debug -- --probe=search-focus-contract --out=artifacts\screenshots\winui-search-focus
  • git diff --check

Note: the WinUI build still reports the existing NETSDK1198 publish-profile warning for win-x64.pubxml; no build errors.

@zhuowcui zhuowcui marked this pull request as ready for review May 17, 2026 22:43
@zhuowcui zhuowcui merged commit aee13f4 into main May 17, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants