[codex] Fix release-mode binding regressions#80
Merged
Conversation
zhuowcui
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause
Release trimming was breaking untyped XAML binding paths in loose templates and related UI surfaces. Debug mode kept enough reflection metadata around for those bindings to appear healthy, but packaged Release lost binding data, leaving controls blank or non-functional. Some filters also held stale request objects between Apply/Clear, so even working controls could leave old filter parameters behind.
Validation
dotnet test JitHub.WinUI.Tests\JitHub.WinUI.Tests.csproj -c Release -p:Platform=x64passed, 92/92.dotnet build JitHub.WinUI\JitHub.WinUI.csproj -c Release -p:Platform=x64succeeded with the existingSvgPreviewtrim warning.