Skip to content

[codex] Fix release-mode binding regressions#80

Merged
zhuowcui merged 3 commits into
mainfrom
codex/fix-release-mode-bindings
May 11, 2026
Merged

[codex] Fix release-mode binding regressions#80
zhuowcui merged 3 commits into
mainfrom
codex/fix-release-mode-bindings

Conversation

@Xueyang-Song

Copy link
Copy Markdown
Collaborator

Summary

  • Replaced trim-fragile loose-template/property-path bindings with code-backed presenters across release-broken UI surfaces.
  • Restored issue and pull request filtering by moving filter templates behind presenters, explicitly committing Apply/Clear values, resetting stale request state, and wiring issue label filters.
  • Added public-preview issue/PR filter handling so packaged release smoke tests can exercise filter behavior without depending on GitHub API state.
  • Added a XAML binding pattern regression test to catch the release-mode binding shape that caused these failures.

Root Cause

Release trimming was breaking untyped XAML binding paths in loose templates and related UI surfaces. Debug mode kept enough reflection metadata around for those bindings to appear healthy, but packaged Release lost binding data, leaving controls blank or non-functional. Some filters also held stale request objects between Apply/Clear, so even working controls could leave old filter parameters behind.

Validation

  • dotnet test JitHub.WinUI.Tests\JitHub.WinUI.Tests.csproj -c Release -p:Platform=x64 passed, 92/92.
  • dotnet build JitHub.WinUI\JitHub.WinUI.csproj -c Release -p:Platform=x64 succeeded with the existing SvgPreview trim warning.
  • Packaged Release smoke: PR State, PR Head, Issue State, and Issue Labels filters applied and Clear restored lists without crashing.
  • Windows Application event log showed 0 JitHub crashes since the final packaged launch.

@zhuowcui zhuowcui marked this pull request as ready for review May 11, 2026 05:59
@zhuowcui zhuowcui merged commit 664af04 into main May 11, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants