fix(packaging): register WinUIEditor activatable classes in MSIX mani…#79
Merged
Conversation
…fest WinUIEdit's targets live in build\native\, which NuGet does not import for managed .NET projects, so the MSIX tooling never generated the required <Extension Category='windows.activatableClass.inProcessServer'> entries for WinUIEditor.dll. Without those entries the OS cannot locate WinUIEditor's activation factory at runtime, causing a STATUS_STOWED_EXCEPTION (0xC000027B) crash inside Microsoft.UI.Xaml.dll on first launch — exactly the failure seen in the Microsoft Partner Center certification report. Fix: add an explicit <WindowsMetadataReference> item pointing at the native WinMD from the WinUIEdit NuGet package. The MSIX tooling's _AddWindowsMetadataReferecesToPackagingOutputs target picks this up and passes it to WinAppSdkGenerateAppxManifest, which harvests all WinRT activatable class IDs (CodeEditorControl, EditorBaseControl, XamlMetaDataProvider) from the WinMD and writes them into the generated AppxManifest.xml. Also add TrimmerRootAssembly directives for WinUIEditorCsWinRT (net8.0) and CommunityToolkit.WinUI.UI.Controls.DataGrid (net5.0) so the AOT/IL trimmer does not strip types that WinUI resolves dynamically through XamlTypeInfo. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…fest
WinUIEdit's targets live in build\native, which NuGet does not import for managed .NET projects, so the MSIX tooling never generated the required entries for WinUIEditor.dll.
Without those entries the OS cannot locate WinUIEditor's activation factory at runtime, causing a STATUS_STOWED_EXCEPTION (0xC000027B) crash inside Microsoft.UI.Xaml.dll on first launch — exactly the failure seen in the Microsoft Partner Center certification report.
Fix: add an explicit item pointing at the native WinMD from the WinUIEdit NuGet package. The MSIX tooling's _AddWindowsMetadataReferecesToPackagingOutputs target picks this up and passes it to WinAppSdkGenerateAppxManifest, which harvests all WinRT activatable class IDs (CodeEditorControl, EditorBaseControl, XamlMetaDataProvider) from the WinMD and writes them into the generated AppxManifest.xml.
Also add TrimmerRootAssembly directives for WinUIEditorCsWinRT (net8.0) and CommunityToolkit.WinUI.UI.Controls.DataGrid (net5.0) so the AOT/IL trimmer does not strip types that WinUI resolves dynamically through XamlTypeInfo.