FIX: replace clock-seeded PRNG with SecureRandom for IV generation#27
Merged
Conversation
The Random PRNG was seeded from Date.now() at construction, making auto-generated IVs predictable. IVMode.getIV4e() now uses SecureRandom.getSecureRandomBytes() directly. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
OpenSSL 3.x generates BEGIN PRIVATE KEY (PKCS#8) by default.
The method now tries PKCS#1 first, then unwraps the PKCS#8 SEQUENCE
{ version, AlgorithmIdentifier, OCTET STRING { RSAPrivateKey } }.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Jens-G
force-pushed
the
fix/secure-random-iv
branch
2 times, most recently
from
a2dae36 to
b8b285f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IVModenow generates IVs viaSecureRandominstead of seeding fromDate.now(), eliminating the predictable-IV vulnerabilityCBCModeTestthat asserts two consecutive auto-generated IVs are distinctCloses #7
Test plan
haxe tests.hxml— newtest_auto_iv_is_uniquepasses, all 1280 assertions green🤖 Generated with Claude Code