Repository navigation
Conversation
A change now lists only the folder whose own entries changed and keeps its subfolders (ScanOptions.keep, core/refresh.py), so a file saved directly in the scanned folder no longer rescans the whole scan. All changed folders are read in one worker and refilled in place, so the view keeps its place, expansion and selection. The native feed no longer stops while folders are read. The scope is captured again only when subfolders changed, and the new feed takes over once armed; an NTFS journal feed reads on from where the refresh began. Directory notifications report the real folder, too many changes read their parent folder whole instead of the root, and the five-minute full reconciliation is gone.
Verified Follow changes natively on the USN journal and on directory notifications: a change in the scanned folder reads only that folder, a folder added during the hand-over is caught from the held journal position, and nothing rescans the whole root. Two costs found on the way: the result navigation redrew every page icon whenever its texts were updated (about 100 ms after each refresh), and a folder removed before it was read asked for its folder again even when that folder had just been read in the same pass.
Source operations now stop only the capture, which reads the tree; the feed keeps reporting, so an operation leaves no gap and a cancelled review no longer reads the whole root. A feed lost during a Recycle Bin move, permanent delete or Undo is still withdrawn by it. A hard link made anywhere on an NTFS volume no longer reads the whole scan: the file's names are looked up by file number and only folders holding one inside the scan are read. The journal is read on at once while records wait, directory notifications get a 256 KiB buffer, and an inotify feed reads the folders it newly watches once armed. macOS follows through one FSEvents stream, which reports folders and says when it dropped events or could not keep up.
The elevation tests released their held launch after 2 s as a fallback; on a loaded runner that came first, so the launch had ended before the close request looked. The recurring review waited 10 s for a scan, analysis, review and move in a row. Both wait longer now. The name lookup test simulated a gone file with OSError's winerror argument, which only Windows sets; it sets the attribute itself now.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Releases what
devhas added since 0.2.15: Follow changes reads only the folders that changed, instead of rescanning the whole scan.Only the changed folder is read (U-20261120-01)
ScanOptions.keep,core/refresh.py), so a file saved directly in the scanned folder no longer rescans everything. A subfolder replaced meanwhile is read whole.No gaps and no needless whole rescans (U-20261120-03)
core/mac_watch.py). It reports folders, and it reports dropped events (whole root) and events it could not keep up with (that folder, read whole).Verified natively, with two fixes (U-20261120-02)
On this machine (administrator, readable C: journal), both the NTFS journal and directory notifications, in a hidden window, on made-up folders:
No case rescanned the whole root.
Worst window stall on a 120,208-entry tree: 29–85 ms.
The result navigation redrew every page icon on each refresh (about 100 ms); icons are now drawn once per colour.
Tests (U-20261120-04)
test_elevation_worker,test_recurring_review) wait longer.Not verified
progress.md#144.Test plan
ruff check .test_folder_refresh.py; refresh, handover, operation and inotify cases intest_change_watch_gui.py; journal handover, name lookup, read-on, buffer and FSEvents cases intest_change_watch.pydevgreen for 4044196