Skip to content

Smoother live scans, waiting actions that explain, and chart keys kept out of the path box - #40

Merged
JE-Chen merged 4 commits into
mainfrom
dev
Nov 19, 2026
Merged

JE-Chen merged 4 commits into
mainfrom
dev

Conversation

@JE-Chen

@JE-Chen JE-Chen commented Nov 19, 2026

Copy link
Copy Markdown
Contributor

Summary

Releases what dev has added since 0.2.12.

A smoother window while a scan runs

  • Live refreshes no longer notify every shown folder row. A tick whose rows did not change notified each shown folder, and Qt then asked hasChildren once per row. Only the root row is notified now; the visible rows are repainted anyway. With 100,000 shown folders such a tick took 342 ms, now 90 ms.
  • Live refreshes are spaced by their cost. Each refresh is timed until the window's event loop is about to wait again (including the layout and painting Qt defers), and the next one waits four times that, between 0.7 s and 5 s. With 100,000 shown folders and new rows on every tick, the window was busy 71% of the time and responsive 18%; now 22% and 79%. The longest stall went from 1,205 ms to 489 ms (one Qt layout of 100,000 rows).

Actions that have to wait say so

  • During a scan, the context menu offered Move to Recycle Bin, Delete permanently and Rescan this folder, but they did nothing, and the menu actions and their shortcuts (Del, F5, Ctrl+F…) were greyed out without a reason. They now stay usable and, when used, say in the status bar and next to the pointer that they wait for the scan (or for another file operation) and how to end the wait. Actions that start a scan themselves wait only for operations. All five languages.

Fix

  • Enter in the chart rescanned the whole root. After a scan started from the path box, keyboard focus stayed there, and the chart's Up, Back, Forward and ancestor buttons take no focus of their own. Enter meant to open a folder in the chart went to the path box and scanned the whole root again; Backspace deleted characters of the path. Starting a scan now moves focus to the folder tree, and the chart buttons hand focus to the chart.

Not verified

  • Measured on made-up trees in a hidden window, not on the reporter's own drive or screen; with more than 100,000 shown rows a single layout still grows with the row count.
  • Japanese and Korean texts were not reviewed by a native speaker.

Test plan

  • ruff check .
  • Related tests locally: tree and GUI 264 passed; actions, removals and menus (37 files) passed; chart, breadcrumb and focus 307 passed (the known long-path test excluded)
  • New tests fail before each fix: test_live_refresh.py, test_busy_notice.py, test_chart_focus.py
  • Tests workflow on dev (Windows 3.11–3.14, Linux, macOS, FreeBSD); one flaky test_recurring.py case and a FreeBSD guest SSH drop passed on rerun

…n folder row

With many folders expanded, a running scan's live refresh kept the window
busy most of the time: unchanged ticks notified every shown folder row,
which made Qt ask hasChildren once per row, and structural ticks relaid out
every expanded row on a fixed 700 ms period.

Unchanged ticks now notify only the root row (the viewport repaint already
shows fresh totals), and LiveRefresh times each refresh until the event
loop is about to wait, waiting four times that (0.7 s to 5 s) before the
next. Measured on 100,000 shown folders: an unchanged tick 342 -> 90 ms;
window share taken by refreshes 71% -> 22% (U-20261118-01).
…ng nothing

During a scan the context menu still offered Move to Recycle Bin, Delete
permanently and Rescan this folder, but they silently returned, and the
menu actions and their shortcuts were greyed out with no explanation.

Actions that read or change the scanned entries now stay enabled while a
scan or source operation runs; using one shows, in the status bar and next
to the pointer, that it waits for the scan (or the other operation) and
how to end the wait. Actions that start a scan themselves wait only for
operations. Removal and rescan checks are unchanged (U-20261118-02).
…root

After a scan started from the path box, keyboard focus stayed there, and
the chart's Up, Back, Forward and ancestor buttons take no focus of their
own. Enter meant to open a folder in the chart reached the path box and
scanned the whole root again; Backspace edited the path.

Starting a scan now moves focus from the path box or start page to the
folder tree, and the chart navigation buttons hand focus to the chart
(U-20261119-01).
@sonarqubecloud

Copy link
Copy Markdown

@JE-Chen
JE-Chen merged commit bab7a1d into main Nov 19, 2026
50 of 52 checks passed

This branch was previously deployed

1 inactive deployment
windows-signing — d6538c0c Deployed Nov 19, 2026 by JE-Chen via build-exe #15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant