Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several foundational improvements to the project, including standardized configuration, CI/CD automation, and restructuring of the solution and sample code. It also removes legacy files and interfaces, paving the way for a cleaner and more maintainable codebase.
Project configuration and structure:
.editorconfigfile to enforce consistent code style and formatting across the project, including indentation settings for different file types.MpesaDaraja.slntoMpesa.Daraja.sln, updating project references, and adding new test and sample projects (Mpesa.Daraja.Sample,Mpesa.Daraja.Tests). [1] [2].vscode/settings.jsonto configure spell checking for domain-specific terms.Directory.Build.propsto centralize .NET build settings, including target framework, language version, and nullable reference types.CI/CD automation:
ci.yml), release (release.yml), and documentation deployment (docs.yml), automating build, test, NuGet publishing, and docs deployment to GitHub Pages. [1] [2] [3]Cleanup and removal of legacy code:
Daraja.App/Program.cs) and old interface and model files fromMpesaDaraja, includingIDarajaClient.cs,IDarajaGateway.cs,DarajaError.cs,PushQueryResponse.cs, andPushResponse.cs. [1] [2] [3] [4] [5] [6]MpesaDaraja.sln.DotSettings.