Skip to content

cli: --filter errors swallowed (unfiltered output, exit 0); typo'd messages #17

Description

@JavaGT

Lane: CLI/UX (sweep 3, F3)
filterMessage() catches all errors and continues (cli/pbjs.js:423-433): a typo'd filter name silently generates the unfiltered root with exit 0. Underlying messages have typos: package not foud, message not foud (cli/util.js:179,191), plus "The filter not work". Reproduced live.

Verdicts: both Confirm Worth exploring. Scope note (grok): the multi-segment resolution bug itself overlaps open upstream protobufjs#2416 — this ticket covers only the swallow-and-continue behavior and the typo'd strings; do not re-file resolution here.

Upstream: protobufjs#2416 (open), protobufjs#2032 (closed) for resolution; swallow behavior + typos unreported.

Decision question: Adopt — unresolvable filter name becomes a hard error (exit 1) and the strings get fixed? Or keep degradable behavior but fix the messages?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions