Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes a terminal-hygiene gap exposed while activating the #194/#163 Wave 2 runtime.
A coordination-bound cutover can legitimately close from the already-supported active PREPARED replacement path: exact replacement source/build/capability identity plus an exact positive workspace/agent witness, with no drain or restart markers. The existing terminal lease release operator accepted only the normal drained + scheduled-restart lineage. After the root carrier was revoked, that left an otherwise terminal lease permanently overlapping the cutover state root and blocked the next cutover.
This change keeps one terminal-hygiene authority and permits lease release for either:
finishaction matches the approved replacement identity and approved finish pair.Expired no-effect recovery, unexpected replacement, capability mismatch, observed replacement, supersession, binding repair, wrong replacement instance, wrong witness pair, non-terminal operations, and non-revoked carriers remain fail-closed.
Exact Candidate evidence:
cb33bb7c6f200141b9797c56efdaf2964c726dcf188388d511019dc6b974e9c8a7fa065ea031b910src/carrier-binding.test.ts: 44/44 PASS, including the new prepared-replacement release and wrong replacement-instance negative controlnpm run typecheck: PASSnpm run build: PASSgit diff --check: PASSNo database surgery, provider routing, OAuth semantics, cutover target rewriting, restart scheduling, or recovery authority is added.