Skip to content

fix: Update how nodetypes are calculated for insertion points#2389

Merged
AKarmanov merged 6 commits into
mainfrom
fix-nodetype-resolution
Jun 11, 2026
Merged

fix: Update how nodetypes are calculated for insertion points#2389
AKarmanov merged 6 commits into
mainfrom
fix-nodetype-resolution

Conversation

@AKarmanov

@AKarmanov AKarmanov commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Description

Update how nodetypes are calculated for insertion points when contribute types are defined on the node.

Checklist

Source code

  • I've shared and documented any breaking change
  • I've reviewed and updated the jahia-depends

Tests

  • I've provided Unit and/or Integration Tests
  • I've updated the parent issue with required manual validations

Tip

Documentation to guide the reviews: How to do a code review

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown

🦜 Chachalog

@jahia/jcontent minor

Create a new entry online or run npx chachalog@0.5.2 prompt to create a new entry locally.

@AKarmanov AKarmanov changed the title fix: Update how donetypes are calculated for insertion points fix: Update how nodetypes are calculated for insertion points Jun 10, 2026
@AKarmanov AKarmanov marked this pull request as ready for review June 10, 2026 16:00
@AKarmanov AKarmanov requested review from a team June 10, 2026 16:00
Comment thread src/javascript/JContent/EditFrame/InsertionPoints.jsx

@gflores-jahia gflores-jahia left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks ok to me but I think we need to maybe start adding some high level overview of the logic for calculating these nodetypes to make it (somewhat) easier to understand.

@jahia-sonarqube

jahia-sonarqube Bot commented Jun 11, 2026

Copy link
Copy Markdown

@AKarmanov AKarmanov merged commit c476df3 into main Jun 11, 2026
60 of 63 checks passed
@AKarmanov AKarmanov deleted the fix-nodetype-resolution branch June 11, 2026 16:17
@github-actions github-actions Bot mentioned this pull request Jun 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants