Skip to content

feat: translate layout in advanced editor#2372

Draft
GauBen wants to merge 32 commits into
mainfrom
feat/translate-in-advanced-editor
Draft

feat: translate layout in advanced editor#2372
GauBen wants to merge 32 commits into
mainfrom
feat/translate-in-advanced-editor

Conversation

@GauBen

@GauBen GauBen commented Jun 5, 2026

Copy link
Copy Markdown
Member

Working on the premises of https://github.com/Jahia/content-versioning/issues/8: the translation layout is now part of the advanced edition layout

image

The two columns were swapped

It should be somewhat easy to add new options (e.g. content versioning) next to edit/translate/advanced options

@github-actions

github-actions Bot commented Jun 5, 2026

Copy link
Copy Markdown

🦜 Chachalog

No changelog entries detected. Learn more about Chachalog.

Create a new entry online or run npx chachalog@0.5.2 prompt to create a new entry locally.

Comment thread src/javascript/ContentEditor/actions/contenteditor/translate/styles.scss Outdated
Comment thread src/javascript/ContentEditor/actions/jcontent/editContent/editContentAction.jsx Outdated
Comment thread src/javascript/ContentEditor/ContentEditor/EditPanel/EditPanelFullscreen.jsx Outdated
Comment thread src/javascript/ContentEditor/editorTabs/EditPanelContent/EditPanelContent.jsx Outdated
Comment thread src/javascript/ContentEditor/editorTabs/EditPanelContent/EditPanelContent.jsx Outdated
Comment thread src/javascript/ContentEditor/editorTabs/EditPanelContent/EditPanelContent.jsx Outdated
Comment thread src/javascript/ContentEditor/editorTabs/registerTabBarActions.js Outdated
Comment thread package.json Outdated
@GauBen

GauBen commented Jun 12, 2026

Copy link
Copy Markdown
Member Author

The tests are failing, I don't know why, I don't know how to run them locally to save time

@GauBen

GauBen commented Jun 12, 2026

Copy link
Copy Markdown
Member Author

@copilot look at the test failures and fix them

Copilot AI commented Jun 12, 2026

Copy link
Copy Markdown

@copilot look at the test failures and fix them

Fixed in a6bb3430. The regression was that normal edit actions were still receiving translate side-by-side context, which could put the editor into the wrong mode. I scoped that context back to the translate action only, then re-ran yarn lint and yarn test locally successfully.

@GauBen

GauBen commented Jun 12, 2026

Copy link
Copy Markdown
Member Author

@copilot Look at the CI integration tests and fix them

Copilot AI commented Jun 12, 2026

Copy link
Copy Markdown

@copilot Look at the CI integration tests and fix them

Fixed in 1fa11ef1. I traced the integration failures to fullscreen tab state not being persisted: after switching tabs/languages, regular edit screens could still inherit translate mode behavior. The fix persists the selected fullscreen tab in editor config and only applies translate-specific read-only/publication logic when the active tab is actually Translate. I re-ran yarn lint, yarn test, and the final validation (CodeQL clean).

@jahia-sonarqube

Copy link
Copy Markdown

Quality Gate failed Quality Gate failed

Failed conditions
7.7% Duplication on New Code (required ≤ 3%)
13 New Maintainability Issues (required ≤ 0)
5 New Reliability Issues (required ≤ 0)
48 Added Technical Debt (required ≤ 0)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants