fix(view): improve edit-mode empty state and accessibility#1
Open
pvollenweider wants to merge 1 commit into
Open
fix(view): improve edit-mode empty state and accessibility#1pvollenweider wants to merge 1 commit into
pvollenweider wants to merge 1 commit into
Conversation
- Escape node name via <c:out> to prevent XSS in edit mode
- Show notice when html is empty, even if css/js are populated,
so CSS/JS-only blocks remain selectable in the editor
- Use cached ${html} var instead of re-reading JCR property
- Collapse nested c:if into single compound condition
- Short-circuit removeHtmlTags when html is already empty
- Add styled placeholder visible only in edit mode (WCAG AA contrast)
- Clarify css field tooltip (EN + FR)
pvollenweider
force-pushed
the
fix/edit-mode-empty-state-accessibility
branch
from
e8c7c12 to
dbeb94d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<c:out>to prevent XSS in edit modehtmlis empty even ifcss/jsare populated — CSS/JS-only blocks are now selectable in the editor${html}var instead of re-reading JCR property on render<c:if>into single compound conditionremoveHtmlTagswhenhtmlis already emptyTest plan
<,>) → escaped correctly in noticemvn testpasses