feat: structure MySQL ALTER TABLE ordering and share table options - #2708
Merged
manticore-projects merged 3 commits intoSep 25, 2026
Merged
manticore-projects merged 3 commits into
manticore-projects merged 3 commits into
Conversation
Signed-off-by: minleejae <mmj9808@gmail.com>
Signed-off-by: minleejae <mmj9808@gmail.com> # Conflicts: # src/main/java/net/sf/jsqlparser/statement/create/table/TableOption.java # src/main/jjtree/net/sf/jsqlparser/parser/JSqlParserCC.jjt
Contributor
|
Please resolve conflicts. |
Signed-off-by: minleejae <mmj9808@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MySQL ALTER TABLE ORDER BY and combined ENGINE / ROW_FORMAT / statistics clauses could remain opaque ALTER actions. This prevented callers from inspecting or changing the ordering and table settings through the AST.
Add AlterExpressionOrderBy using the existing OrderByElement model and expression traversal. Reuse MySqlTableOption for CREATE and ALTER row format/statistics settings, with explicit option kinds and validation. Keep ORDER BY at the end of the action list: its commas belong to the column list, matching MySQL grammar and execution behavior.
Validation: full Gradle check, including the grammar ambiguity gate; AST mutation/traversal tests, following statements, mixed action boundaries and invalid option values. The two audited ALTER statements execute with matching selected catalog results for original, toString and deparser output on MySQL 9.7.2 and 26.7.0.
Additional execution checks on both MySQL versions confirm that table options before ORDER BY are accepted, while ENGINE or ADD COLUMN after its column list are rejected; matching regression tests cover these boundaries.