Repository navigation
TSQL/MS SQL Server statements/syntax not supported. #1563
Description
Activity
Did you investigate this issue further?
@manticore-projects I revisited the two Sakila scripts linked in this issue and verified them against current
master(8e2d660), usingDialect.SQLSERVERwith unsupported-statement fallback disabled.Both scripts parse successfully without modifying or preprocessing the input:
Input Parsed statements Result Schema script 70 Pass Current insert-data script 46,326 Pass Insert-data script as it existed when this issue was opened 46,326 Pass I also deparsed and reparsed each complete script and checked that statement types, counts, and rendered SQL were preserved. No
UnsupportedStatementnodes were produced.The relevant syntax gaps were addressed by:
- Support dialect-specific CREATE INDEX definitions #2586: SQL Server index definitions
- Accept SQL Server CREATE TABLE trailing commas with shared element parsing #2603: trailing commas in SQL Server
CREATE TABLE - Support SQL Server SET IDENTITY_INSERT with a structured table target #2605:
SET IDENTITY_INSERT
All three fixes are included in the
jsqlparser-5.4tag; the verification above was run on currentmaster.Since the original reproductions now pass, would you agree that this issue can be closed as resolved?
Absolutely, great job!
We need to mention this on the Website as well!
From dbeaver/dbeaver#16756.
Two large TSQL files:
https://github.com/jOOQ/sakila/blob/main/sql-server-sakila-db/sql-server-sakila-schema.sql
https://github.com/jOOQ/sakila/blob/main/sql-server-sakila-db/sql-server-sakila-insert-data.sql