fix(scoring): anchor the draft title pattern to genuine markers#1529
Open
Dexterity104 wants to merge 1 commit into
Open
fix(scoring): anchor the draft title pattern to genuine markers#1529Dexterity104 wants to merge 1 commit into
Dexterity104 wants to merge 1 commit into
Conversation
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1529 +/- ##
=======================================
Coverage 95.45% 95.45%
=======================================
Files 195 195
Lines 21121 21121
Branches 7637 7637
=======================================
Hits 20161 20161
Misses 383 383
Partials 577 577
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
classifyOpenPullRequestmatched any title beginning with the letters "draft", so real work such as "Drafting a new feature", "Draftsman tool", and "draft-js upgrade" was classified as a draft.merge_readyandstale_likely_closebuckets, sopendingMergedPrCountandpendingClosedPrCountindetectPendingPrScenariocame out lower than reality whenever one of those PRs was otherwise countable.normalizeTitleto strip a draft prefix for duplicate detection, so the dedup key for those titles was corrupted (for example "Draft tooling" collapsed onto "tooling").DRAFT_TITLE_PATTERNnow matches only genuine markers ([draft],Draft:, andDraft -with a spaced dash) and is shared by both the classifier and the normalizer so they stay consistent. Requiring a space before the dash keeps hyphenated names such asdraft-jsanddraft-modefrom matching.Scope
type(scope): short summaryConventional Commit format, for examplefix(api): restore profile access checks.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Validation
git diff --checknpm run actionlintnpm run typechecknpm run test:coveragelocally;codecov/patchrequires ≥97% coverage of the lines AND branches you changed (aim for 98%+ on your diff so CI variance does not fail near the threshold). Global coverage is a non-blocking trend with a loose 90% backstop, not the gate.npm run test:workersnpm run build:mcpnpm run test:mcp-packnpm run ui:openapi:checknpm run ui:lintnpm run ui:typechecknpm run ui:buildnpm audit --audit-level=moderateIf any required check was skipped, explain why:
npm run test:ciplusnpm audit --audit-level=moderate, all green.Safety
UI Evidencesection below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.UI Evidence
Not applicable. The change is backend only, with no visible UI, frontend, docs, or extension changes.
Notes
isDraftPullRequest. Regression tests cover the misclassified titles, the genuine markers, and the dedup key behavior innormalizeTitle.