fix(signals): group contributor open PRs by repo case-insensitively#1527
Open
galuis116 wants to merge 1 commit into
Open
fix(signals): group contributor open PRs by repo case-insensitively#1527galuis116 wants to merge 1 commit into
galuis116 wants to merge 1 commit into
Conversation
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1527 +/- ##
=======================================
Coverage 95.45% 95.46%
=======================================
Files 195 195
Lines 21121 21123 +2
Branches 7637 7637
=======================================
+ Hits 20161 20165 +4
Misses 383 383
+ Partials 577 575 -2
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1526.
groupByRepoinbuildContributorOpenPrMonitorbucketed a contributor's open PRs by the rawpr.repoFullName, while every other repo-name operation in the same function is case-insensitive (the registered-repo set, the open-PR filter, the repo lookup). GitHub repo names are case-insensitive, so case-variantrepoFullNamevalues for one repo split into separate groups — under-counting per-repo open PRs, running duplicate detection only within each partial group, and queryinglistPullRequestsonce per casing.What changed
groupByReponow keys buckets onpr.repoFullName.toLowerCase(), matching the function's own repo-name handling.repoFullNamefrom a bucket's first PR (its original casing) for the case-sensitive per-repo DB queries — the established key-by-lower / keep-original pattern used incontributor-evidence-graph.ts.Scope
CONTRIBUTING.md; nosite//CNAME/VitePress.Validation
git diff --checknpm run typechecknpm run test:coveragelocally (4619 passed); the new grouping lines are covered by a case-variant test, and the existing same-casing tests are unchanged.npm run test:workersnpm audit --audit-level=moderateIf any required check was skipped, explain why:
Safety
Notes
src/signals/contributor-open-pr-monitor.ts; mirrors the case-insensitive repo handling already present in the same function and incontributor-evidence-graph.ts.