feat(review): read promoted self-tune overrides into the live gate#1495
Merged
Conversation
The self-improvement loop (GITTENSORY_REVIEW_SELFTUNE, default OFF) shadow-soaks and promotes tightening-only overrides into tunables_overrides, but nothing read them back — a promoted override sat inert. Wire the live read-back in resolveRepositorySettings: applySelfTuneOverrideToSettings translates a promoted confidenceFloor into gittensory's native readiness tunable by RAISING an existing qualityGateMinScore to round(floor*100) via max(). By construction it can only tighten — it never creates a readiness gate the operator didn't set, and never lowers one — so the always-tightening recommendation reaches the live gate with no risk of loosening it. Flag-OFF the override is never read and settings are byte-identical.
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1495 +/- ##
=======================================
Coverage 95.45% 95.45%
=======================================
Files 195 195
Lines 21111 21121 +10
Branches 7632 7637 +5
=======================================
+ Hits 20151 20161 +10
Misses 383 383
Partials 577 577
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The self-improvement loop (
GITTENSORY_REVIEW_SELFTUNE, default OFF) already shadow-soaks and promotes tightening-only overrides intotunables_overrides— but nothing read them back, so a promoted override sat inert (the read-back was explicitly deferred inselftune-wire.tspending a gittensory-native tightening tunable).This wires the live read-back in
resolveRepositorySettings:applySelfTuneOverrideToSettings(pure) translates a promotedconfidenceFloor[0,1] into gittensory's native readiness tunable by raising an existingqualityGateMinScoretoround(confidenceFloor * 100)viamax().Closes the last open gap in the converged self-improvement loop.
Scope
src/settings/repository-settings.ts— the flag-gated read-back + pure translatorsrc/review/selftune-wire.ts— comment update (the deferred read-back is now wired)test/unit/selftune-readback.test.ts— newValidation
npm run test:coverage— 4618 passed;repository-settings.tsat 100% line+branch on the diffnpm run typecheck— cleanSafety