Skip to content

fix(mcp): restore the stale compatibility status for supported-but-behind clients #1407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
minion1227 wants to merge 2 commits into from
+12 −4
Closed

fix(mcp): restore the stale compatibility status for supported-but-behind clients #1407

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c673237
fix(mcp): restore the stale compatibility status for supported-but-be…
minion1227 Jun 25, 2026
062dba9
Merge branch 'main' into minion_mcp-stale
JSONbored Jun 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/services/mcp-compatibility.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,10 @@ export function classifyMcpClientVersion(version: string | null | undefined): Mc
const minimumComparison = compareMcpSemver(version, MINIMUM_SUPPORTED_MCP_VERSION);
if (minimumComparison === null) return "unknown";
if (minimumComparison < 0) return "incompatible";
return "current";
// A version at/above the minimum but below the latest recommended is supported-but-behind → "stale".
// (The flat "current" was correct only while MINIMUM === LATEST_RECOMMENDED; #745 reopened the gap.)
const latestComparison = compareMcpSemver(version, LATEST_RECOMMENDED_MCP_VERSION)!;
return latestComparison < 0 ? "stale" : "current";
}

function parseSemver(version: string) {
Expand Down
9 changes: 7 additions & 2 deletions test/unit/mcp-compatibility.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,12 @@ describe("MCP compatibility telemetry", () => {
expect(classifyMcpClientVersion("0.2.1")).toBe("incompatible");
expect(classifyMcpClientVersion("0.3.0")).toBe("incompatible");
expect(classifyMcpClientVersion("0.4.0")).toBe("incompatible");
expect(classifyMcpClientVersion("0.5.0")).toBe("current");
// >= minimum (0.5.0) but < latest recommended (0.6.0) → supported-but-behind → "stale".
expect(classifyMcpClientVersion("0.5.0")).toBe("stale");
expect(classifyMcpClientVersion("0.5.9")).toBe("stale");
// At/above the latest recommended → "current".
expect(classifyMcpClientVersion("0.6.0")).toBe("current");
expect(classifyMcpClientVersion("0.7.1")).toBe("current");
expect(classifyMcpClientVersion("not-a-version")).toBe("unknown");
expect(classifyMcpClientVersion(undefined)).toBe("unknown");
});
Expand Down Expand Up @@ -50,7 +55,7 @@ describe("MCP compatibility telemetry", () => {
clientVersion: "0.5.0",
metadata: {
packageName: "@example/custom-mcp",
compatibilityStatus: "current",
compatibilityStatus: "stale",
},
});
});
Expand Down
2 changes: 1 addition & 1 deletion test/unit/mcp-server-telemetry.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ describe("MCP server telemetry", () => {
clientVersion: "0.5.0",
metadata: expect.objectContaining({
toolName: "gittensory_local_status",
compatibilityStatus: "current",
compatibilityStatus: "stale",
}),
}),
]);
Expand Down