fix(orb): bound relay retry fan-out#1400
Open
JSONbored wants to merge 1 commit into
Open
Conversation
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1400 +/- ##
=======================================
Coverage 95.33% 95.34%
=======================================
Files 192 192
Lines 20750 20754 +4
Branches 7500 7500
=======================================
+ Hits 19783 19787 +4
Misses 383 383
Partials 584 584
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
RELAY_RETRY_BATCH_SIZEand applyingORDER BY created_at, delivery_id LIMIT ?to the select insrc/orb/relay.ts.RELAY_RETRY_CONCURRENCYand replacing the unboundedPromise.all(results.map(...))with chunkedPromise.allloops that process slices ofresultsof sizeRELAY_RETRY_CONCURRENCY.attemptsand rows are still pruned by TTL/attempt budget.PAGES retry work and bounds concurrent forwardsintest/integration/orb-relay.test.tsthat seeds more failures than one batch and asserts only one page is attempted with concurrency capped.Testing
npx vitest run test/integration/orb-relay.test.tsand the integration suite fororb-relaypassed (27 tests passed).npm run typecheckwhich completed successfully andgit diff --checkwhich reported no issues.npm run test:coverage -- --run test/integration/orb-relay.test.tsbut it failed due to a local dependency remapping error (ast-v8-to-istanbulreceiving an incompatiblejs-tokensversion), not related to the logic change.npm audit --audit-level=moderatebut it could not complete in this environment due to a registry/audit endpoint error (403).Codex Task