Skip to content

fix(review): align guarded rename comment holds#1399

Merged
JSONbored merged 3 commits into
mainfrom
codex/fix-guardrail-logic-for-renamed-files
Jun 26, 2026
Merged

fix(review): align guarded rename comment holds#1399
JSONbored merged 3 commits into
mainfrom
codex/fix-guardrail-logic-for-renamed-files

Conversation

@JSONbored

Copy link
Copy Markdown
Owner

Motivation

  • Prevent a misleading public review comment by ensuring the unified-comment guardrail check uses the same path set as the auto-maintenance disposition so renamed/moved guarded files (via previousFilename) are treated as guarded.

Description

  • Replace the comment-side guardrail check with isGuardrailHit(changedPathsForGuardrail(unifiedFiles), await loadHardGuardrailGlobs(...)) and add a regression unit test for a guarded workflow file rename, touching src/queue/processors.ts and test/unit/agent-guardrail-paths.test.ts.

Testing

  • Ran the targeted unit tests npx vitest run test/unit/agent-guardrail-paths.test.ts test/unit/unified-comment-bridge.test.ts, which both passed.
  • Ran npm run typecheck, which passed.
  • Attempted npm run test:coverage, but coverage generation failed during remapping (ast-v8-to-istanbul / jsTokens error), so a full coverage report could not be produced here.
  • Attempted npm audit --audit-level=moderate, which failed due to registry access returning 403 Forbidden.

Codex Task

@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jun 25, 2026
@superagent-security

Copy link
Copy Markdown

Superagent didn't find any vulnerabilities or security issues in this PR.

@codecov

codecov Bot commented Jun 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.36%. Comparing base (c962a22) to head (1ffdb80).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1399      +/-   ##
==========================================
- Coverage   95.36%   95.36%   -0.01%     
==========================================
  Files         192      192              
  Lines       20816    20815       -1     
  Branches     7529     7529              
==========================================
- Hits        19851    19850       -1     
  Misses        383      383              
  Partials      582      582              
Files with missing lines Coverage Δ
src/queue/processors.ts 88.06% <ø> (-0.01%) ⬇️
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jun 25, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
gittensory-ui be8a2a4 Commit Preview URL

Branch Preview URL
Jun 25 2026, 11:04 PM

@JSONbored JSONbored self-assigned this Jun 26, 2026
@JSONbored JSONbored merged commit a78e75f into main Jun 26, 2026
18 checks passed
@JSONbored JSONbored deleted the codex/fix-guardrail-logic-for-renamed-files branch June 26, 2026 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aardvark codex size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant