fix(review): align guarded rename comment holds#1399
Merged
Conversation
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1399 +/- ##
==========================================
- Coverage 95.36% 95.36% -0.01%
==========================================
Files 192 192
Lines 20816 20815 -1
Branches 7529 7529
==========================================
- Hits 19851 19850 -1
Misses 383 383
Partials 582 582
🚀 New features to boost your workflow:
|
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
gittensory-ui | be8a2a4 | Commit Preview URL Branch Preview URL |
Jun 25 2026, 11:04 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
previousFilename) are treated as guarded.Description
isGuardrailHit(changedPathsForGuardrail(unifiedFiles), await loadHardGuardrailGlobs(...))and add a regression unit test for a guarded workflow file rename, touchingsrc/queue/processors.tsandtest/unit/agent-guardrail-paths.test.ts.Testing
npx vitest run test/unit/agent-guardrail-paths.test.ts test/unit/unified-comment-bridge.test.ts, which both passed.npm run typecheck, which passed.npm run test:coverage, but coverage generation failed during remapping (ast-v8-to-istanbul/jsTokenserror), so a full coverage report could not be produced here.npm audit --audit-level=moderate, which failed due to registry access returning403 Forbidden.Codex Task