fix(signals): redact plural economic and identity terms#1389
Conversation
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1389 +/- ##
=======================================
Coverage 95.37% 95.37%
=======================================
Files 192 192
Lines 20857 20857
Branches 7542 7542
=======================================
Hits 19892 19892
Misses 383 383
Partials 582 582
🚀 New features to boost your workflow:
|
|
Important Gittensory found maintainer review notesScoped related-work signals were found for this PR. They are advisory unless the gate reports a blocker. Readiness score: 48/100
Signal definitions
Review context
Maintainer notes
Contributor next steps
💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers. |
JSONbored
left a comment
There was a problem hiding this comment.
Of the two identical submissions this is the one we keep — its test covers the plural cases the twin omits, pinning more of the new branch. The fix is right: hoisting \w* across the singular nouns closes the gap. Merge this, close #1387.
JSONbored
left a comment
There was a problem hiding this comment.
Of the two identical submissions this is the one we keep — its test covers the plural cases the twin omits, pinning more of the new branch. The fix is right: hoisting \w* across the singular nouns closes the gap. Merge this, close #1387.
Summary
PUBLIC_UNSAFE_TERMSinsrc/signals/redaction.tsis the canonical public/private boundary behindisPublicSafeText, but onlyrewardandscorecarried a wildcard suffix. The remaining economic and identity nouns were bare, so the trailing word boundary in\b(...)\blanded before a plural "s" and letwallets,hotkeys,coldkeys,mnemonics,payouts, andrankingspass as public-safe.\w*suffix, mirroring the existingreward\w*/score\w*and the plural hardening already merged for the sibling comment sanitizer insrc/github/commands.ts.farmingis a gerund and thetrust/reviewabilitycompounds stay bare, since "trust scores" is already covered byscore\w*.Scope
type(scope): short summaryConventional Commit format, for examplefix(api): restore profile access checks.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Validation
git diff --checknpm run actionlintnpm run typechecknpm run test:coveragenpm run test:workersnpm run build:mcpnpm run test:mcp-packnpm run ui:openapi:checknpm run ui:lintnpm run ui:typechecknpm run ui:buildnpm audit --audit-level=moderateIf any required check was skipped, explain why:
Safety
UI Evidencesection below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.UI Evidence
Not applicable. This is a backend-only change to the redaction primitive with no visible UI, frontend, docs, or extension surface.
Notes
PUBLIC_UNSAFE_TERMSconsistent with the plural hardening already shipped for the comment sanitizer, so the public boundary is uniform across surfaces.(?:...)\w*form shares a single suffix and is behaviorally identical to writing the suffix per term, verified against the original by an exhaustive comparison with zero regressions.