fix(orb): drop check_run from relay forward set#1383
Merged
Conversation
check_run events (one per CI job per repo) form a CI firehose — thousands per day — that would flood brokered self-host containers with events they can't act on. check_suite fires once per push/PR sync and is the only signal the re-review trigger needs (processors.ts handles both, so dropping check_run here is lossless for containers). Advances #1372
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1383 +/- ##
=======================================
Coverage 95.35% 95.35%
=======================================
Files 191 191
Lines 20711 20711
Branches 7488 7488
=======================================
Hits 19750 19750
Misses 380 380
Partials 581 581
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
check_runevents are fired once per CI job per repo — at the scale of abusy monorepo that's thousands of events per day. Forwarding them to
brokered self-host containers creates a CI firehose: the container receives
events it can't meaningfully act on and burns queue capacity.
check_suiteis sufficient: it fires once per push/PR sync, and there-review trigger in
processors.ts(eventName !== "check_run" && eventName !== "check_suite") handles both. Droppingcheck_runfromRELAY_FORWARD_EVENTSis therefore lossless for all brokered containers.A regression assertion added to the existing skip-test pins
check_runasintentionally excluded with an explanatory comment so no future refactor
accidentally re-adds it.
Scope
Validation
npx vitest run test/integration/orb-relay.test.ts— 19 tests, all passnpm run test:ci— 258 test files passed, 0 failedSafety