Fix routing removed-children memory leak on JavaFX 25#115
Merged
Conversation
…ng TextFlow leak test The TextFlow-removed-children leak reproduces on JavaFX 25 headless rendering. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…is hidden Setting the container not-tree-visible during the swap makes Parent skip peer.addToRemoved, so the removed page is not retained by the NG peer. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
FlorianKirmaier
force-pushed
the
fix/routing-removed-children-leak
branch
from
1688ce5 to
25a17cd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed pages were retained via the container's NG peer
removed-list under JavaFX 25 headless rendering. First commit bumps jpro-platform to JavaFX 25.0.2 +jfx-25-sandecMonocle and adds the failing routing reproducer; second commit fixes it by swapping page content while the container is not tree-visible (soParentskipspeer.addToRemoved).🤖 Generated with Claude Code