Patched performance bug in quickload behaviour#1340
Open
tayloroxelgren wants to merge 1 commit into
Open
Conversation
Member
|
There is no real measurable performance gain here that I can tell. Flipping the logic from 31 out of 32 sounds to only printing every 32 sounds doesn't save very many draw calls. It does not result in fewer registrations being made which is what really takes the time on load. |
Author
|
I just reran the quickload test with and without this change. Each case was run 10 times on Without change: With the change: I agree it doesn't reduce the number of registrations. The difference comes from reducing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes what appears to be a quickload performance bug in Jedi Outcast single player.
During JK2 SP sound precache, the loading screen text was updated for nearly every sound entry :
I believe this was just a long standing bug as the Jedi Academy code has similar code but it is written like so.
In my local testing, it resulted in a 20-25% reduction in quickload times and 2-5% for cold loads.