Improve new macOS icons#1335
Merged
Merged
Conversation
SomaZ
approved these changes
Jun 3, 2026
taysta
approved these changes
Jun 22, 2026
taysta
left a comment
taysta
left a comment
Contributor
There was a problem hiding this comment.
Tested locally on mac, fixes the previously broken icons.
ensiform
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SomaZ's icons from #1272 had a white background by default, so I matched them better to the Windows icons. The OpenJO icon also appeared incorrectly in Finder at smaller sizes because I believe some icon resolutions were missing from the .icns file. That is fixed now too. (ignore the build_ded.yml file. I did not mean to include that in this.)