Skip to content

[SP] Fix animation events not playing for certain npc variants#1333

Open
TwelveEyes wants to merge 1 commit into
JACoders:masterfrom
TwelveEyes:fix-animevents
Open

[SP] Fix animation events not playing for certain npc variants#1333
TwelveEyes wants to merge 1 commit into
JACoders:masterfrom
TwelveEyes:fix-animevents

Conversation

@TwelveEyes

Copy link
Copy Markdown
Contributor

The original code works off the assumption that NPC_type will always match the playerModel. This is okay for most cases, but obviously doesn't work for the stormtrooper variants (e.g. NPC_type stormtrooper2 does not match playerModel stormtrooper). Because of this, the variants do not get stormtrooper animevents applied to them. Passing along the NPC_type to G_ParseAnimationEvtFile to record as the modelIndex fixes this (NPC_type.handle() will then correctly equal the modelOnly short).

PR #1310 does not fix the issue, and in fact breaks the animevents for the non-variant stormtrooper.

Fixes #1287

@TwelveEyes TwelveEyes requested a review from a team as a code owner May 26, 2026 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JA SP - Stormtrooper Death “Clank” Sounds Don’t Play for NPC Variants

1 participant