Design proposal for new API#1
Draft
naritanara wants to merge 7 commits into
Draft
Conversation
Member
There was a problem hiding this comment.
In this new API, I understand that the instruction table array stores multiple traces, instead of a single trace divided into different instruction tables. Is that correct?
Member
Author
There was a problem hiding this comment.
I just fixed the signatures for what I was intending. The expected flow is:
- izumi_prepare() to init the parser and get a handle
- izumi_parse() to add a table to the array (a size hint is provided to achieve asyncronous parsing)
- izumi_done() to invalidate the handle and free all parsing resources, except the table array, which will probably outlive the parser.
If multiple traces are open, multiple izumi_handles are needed.
Member
Author
|
How to parser:
|
Member
|
This seems good, I will start porting the previous version of the library to the new API and see if there is something missing that would be needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new api is under a new namespace to make it easier to review, when approved it will be moved to the current API location. Having this PR allows me to receive feedback and slowly adjust the API until we find a set of headers that we are happy to commit to.
Summary: