Skip to content

cardano-diffusion:ping - allow for optparse-applicative-fork#5392

Merged
coot merged 1 commit into
mainfrom
coot/optparse-applicative-fork
Jun 26, 2026
Merged

cardano-diffusion:ping - allow for optparse-applicative-fork#5392
coot merged 1 commit into
mainfrom
coot/optparse-applicative-fork

Conversation

@coot

@coot coot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Description

cardano-cli is using optparse-applicative-fork, at least until IntersectMBO/cardano-cli#1390 is merged.

Checklist

Quality

  • Commit sequence makes sense and have useful messages, see ref.
  • New tests are added and existing tests are updated.
  • Self-reviewed the PR.

Maintenance

  • Linked an issue or added the PR to the current sprint of ouroboros-network project.
  • Added labels.
  • Updated changelog files.
  • The documentation has been properly updated, see ref.

@coot
coot requested a review from a team as a code owner June 25, 2026 08:32
@github-project-automation github-project-automation Bot moved this to In Progress in Ouroboros Network Jun 25, 2026
@coot
coot force-pushed the coot/optparse-applicative-fork branch 2 times, most recently from 613d008 to 7f2ed61 Compare June 25, 2026 08:54
@coot
coot force-pushed the coot/optparse-applicative-fork branch from 7f2ed61 to 8448c64 Compare June 25, 2026 10:50
@coot coot added the cardano-ping Iessues / PRs related to cardano-ping label Jun 25, 2026
@coot coot self-assigned this Jun 25, 2026

@karknu karknu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coot
coot added this pull request to the merge queue Jun 26, 2026
Merged via the queue into main with commit 613f8a1 Jun 26, 2026
13 of 14 checks passed
@coot
coot deleted the coot/optparse-applicative-fork branch June 26, 2026 10:35
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Ouroboros Network Jun 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cardano-ping Iessues / PRs related to cardano-ping

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants