Skip to content

[repo-assist] perf: cache sitemap lookups in MCP query service #1490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
github-actions wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[repo-assist] perf: cache sitemap lookups in MCP query service #1490

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 15 additions & 12 deletions EssentialCSharp.Web/Services/BookToolQueryService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,20 +7,29 @@ namespace EssentialCSharp.Web.Services;

public sealed class BookToolQueryService : IBookToolQueryService
{
private readonly ISiteMappingService _siteMappingService;
private readonly IGuidelinesService _guidelinesService;
private readonly string _siteUrl;
private readonly List<SiteMapping> _orderedMappings;
private readonly Dictionary<int, List<SiteMapping>> _mappingsByChapter;

public BookToolQueryService(
ISiteMappingService siteMappingService,
IGuidelinesService guidelinesService,
IOptions<SiteSettings> siteSettings)
{
_siteMappingService = siteMappingService;
_guidelinesService = guidelinesService;
_siteUrl = string.IsNullOrWhiteSpace(siteSettings.Value.BaseUrl)
? "https://essentialcsharp.com"
: siteSettings.Value.BaseUrl.TrimEnd('/');

_orderedMappings = siteMappingService.SiteMappings
.OrderBy(mapping => mapping.ChapterNumber)
.ThenBy(mapping => mapping.PageNumber)
.ThenBy(mapping => mapping.OrderOnPage)
.ToList();
_mappingsByChapter = _orderedMappings
.GroupBy(mapping => mapping.ChapterNumber)
.ToDictionary(group => group.Key, group => group.ToList());
}

public ChapterListToolResult GetChapterList()
Expand Down Expand Up @@ -196,18 +205,12 @@ private SiteMapping ResolveSection(string sectionKey) =>
?? throw new McpException($"Section '{sectionKey}' not found. Use GetChapterSections or GetChapterList to discover valid section slugs.");

private List<SiteMapping> GetOrderedMappings() =>
_siteMappingService.SiteMappings
.OrderBy(mapping => mapping.ChapterNumber)
.ThenBy(mapping => mapping.PageNumber)
.ThenBy(mapping => mapping.OrderOnPage)
.ToList();
_orderedMappings;

private List<SiteMapping> GetChapterMappings(int chapter) =>
_siteMappingService.SiteMappings
.Where(mapping => mapping.ChapterNumber == chapter)
.OrderBy(mapping => mapping.PageNumber)
.ThenBy(mapping => mapping.OrderOnPage)
.ToList();
_mappingsByChapter.TryGetValue(chapter, out List<SiteMapping>? mappings)
? mappings
: [];

private BookTocItemResult MapTocItem(SiteMappingDto item)
{
Expand Down