feat(pam): browser-based RDP support with session recording#227
feat(pam): browser-based RDP support with session recording#227bernie-g wants to merge 3 commits into
Conversation
Add RDCleanPath protocol support, browser RDP session handling via Gateway, and session recording capture for Windows RDP connections.
|
💬 Discussion in Slack: #pr-review-cli-227-feat-pam-browser-based-rdp-support-with-session-recording Posted by Review Police — reviews, comments, new commits, and CI failures will stream into this channel. |
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 9387833 | Triggered | Generic Password | c111230 | packages/pam/handlers/rdp/native/src/rdcleanpath.rs | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c111230dda
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
- Pass domain to connector_config_browser for AD credential injection - Preserve leftover bytes after RDCleanPath PDU parsing - Update caps.rs module doc to reflect actual codec advertisement
1 participant
Description 📣
Adds CLI support for browser-based RDP sessions, including the Rust FFI bridge for IronRDP and session recording event handling.
Type ✨
Tests 🛠️
Tested locally with Windows Server RDP connections via browser and native client.