[IULRDC-209] restrict zip_download#233
Open
aploshay wants to merge 4 commits into
Open
Conversation
Contributor
aploshay
commented
May 15, 2026
aploshay
commented
- removes zip_download from routing, when disabled via settings
- adds #large_file? method to detect Fedora-backed files that are above Fedora-storage size limit
- zip_download now excludes large files, in addition to archive (SDA-only) files
rdlebeau
requested changes
May 15, 2026
Contributor
rdlebeau
left a comment
rdlebeau
left a comment
There was a problem hiding this comment.
Requesting unit testing for the export_file_sets_to function in the data_sets_controller.rb file.
| "Emails did not match" # + ": '#{user_email_one}' != '#{user_email_two}'" | ||
| end | ||
|
|
||
| def export_file_sets_to( target_dir:, |
Contributor
There was a problem hiding this comment.
I think we need unit testing for the export_file_sets_to function in the data_sets_controller.rb file.
| @@ -0,0 +1,49 @@ | |||
| RSpec.shared_examples "PresentsArchiveFile behaviors" do |archive_file_object_factory| | |||
| # expects archive_file_archive_file_object present as subject | |||
Contributor
There was a problem hiding this comment.
I think this comment is meant to say, "expects archive_file_object present as subject".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.