33 add calc record logic#39
Merged
Merged
Conversation
aqshafei
reviewed
Sep 26, 2025
| + f" Config settings are:\n {self.config_settings} \n Initial value:\n {self.initial_value}\n" | ||
| ) | ||
|
|
||
| kws = {} |
Contributor
There was a problem hiding this comment.
would changing kws to kwargs be more descriptive variable name?
I know some people in python use both. I think other files uses kws
Contributor
Author
There was a problem hiding this comment.
I agree, it's best to be consistent. I've renamed kws to kwargs throughout.
aqshafei
approved these changes
Sep 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a calc rule that calculates the value for a PV based on other PVs and a string that defines the calculation. The config reader and pvrecipe have been updated to add support for the calc rule. A method has been added to the server class so that the server object can be used to return the value of a PV either directly using the SharedPV object if it is local to the server or using a Context get if the PV is remote. This also fixes a small bug in the concurrency model where p4p.client.raw.Context in server.Server was not being substituted by the thread or asyncio versions of Context. Support for NTScalarArrays will be added in the future.