#12464 update code to work with both versions of display value string#12469
Merged
Conversation
pdurbin
reviewed
Jun 16, 2026
pdurbin
left a comment
pdurbin
left a comment
Member
There was a problem hiding this comment.
Just a tiny comment. I haven't tested the code but I'm ready to approve, once the tests pass.
|
coverage: 25.024% (-0.001%) from 25.025% — 12464-fix-display-for-trailing-comma into develop |
This comment has been minimized.
This comment has been minimized.
1 similar comment
|
📦 Pushed preview images as 🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
pdurbin
approved these changes
Jun 16, 2026
github-project-automation
Bot
moved this from In Review 🔎
to Ready for QA ⏩
in IQSS Dataverse Project
stevenwinship
moved this from Ready for QA ⏩
to QA - OK to Merge 🔥
in IQSS Dataverse Project
Contributor
|
github-project-automation
Bot
moved this from QA - OK to Merge 🔥
to Merged 🚀
in IQSS Dataverse Project
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Fixes the removal of the trailing comma in a Compound Value field regardless of whether the Display Value string is "VALUE," or "VALUE, ".
Which issue(s) this PR closes:
Special notes for your reviewer: Probably a more elegant way to do this, but I wanted to make sure it would work for the two display value strings that we know about.
Suggestions on how to test this: Remember for the geospatial it will remove the trailing comma for each given group of values (Country, State, City). There are no commas separating the groups - they are put on a new line. So if all your geospatial items are countries then there are no commas at all.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?: no. fixing something introduced by another PR
Additional documentation: