Fixing flaky IT tests#12466
Merged
Merged
Conversation
stevenwinship
added
Size: 3
stevenwinship
force-pushed
the
12463-fix-flaky-tests
branch
from
f241795 to
8e705b4
Compare
|
Coverage is 25.025% — 12463-fix-flaky-tests into develop. No base build found for |
This comment has been minimized.
This comment has been minimized.
1 similar comment
|
📦 Pushed preview images as 🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
Test Results403 tests 388 ✅ 33m 49s ⏱️ Results for commit 8e705b4. |
stevenwinship
moved this from In Progress 💻
to Ready for Review ⏩
in IQSS Dataverse Project
pdurbin
reviewed
Jun 15, 2026
pdurbin
left a comment
pdurbin
left a comment
Member
There was a problem hiding this comment.
I see tests are passing. Great. I have a question, though.
| found = true; | ||
| } | ||
| } | ||
| assertTrue(found, "Root dataverse not found in my collection list"); |
Member
There was a problem hiding this comment.
assertTrue expects "found" to be true. And "found" is set to true when the root dataverse is found right? So shouldn't the message say "Root dataverse WAS found" rather than "NOT found"?
Contributor
Author
There was a problem hiding this comment.
assert only displays the string when the test fails. I.e. if found = false
pdurbin
approved these changes
Jun 15, 2026
github-project-automation
Bot
moved this from In Review 🔎
to Ready for QA ⏩
in IQSS Dataverse Project
github-project-automation
Bot
moved this from Ready for QA ⏩
to Merged 🚀
in IQSS Dataverse Project
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Some tests fail due to the state left over by other tests. This will take those into account when testing.
Which issue(s) this PR closes:#12463
Special notes for your reviewer: The main issue was with multiple dataverses being created that threw off the counts.
Suggestions on how to test this: no need as these are tests
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: