docs: v0.41.0 staleness sweep - #468
Merged
Merged
Conversation
Mechanical checks over the docs against v0.41.0 (identifier scan, GETTING_STARTED snippets compiled and server setup run with real values, behaviour claims for this release's changes, link and anchor check). Every identifier resolves and every snippet compiles and runs; three fixes: - conformance/server/oidf-config/README.md: the Client Credentials Grant heading carried its config file names, so GitHub's anchor wasn't #client-credentials-grant and both links to it were dead. The names move into the section. - GETTING_STARTED.md step 5: the consent submission needs the InteractionRequest again; say how to keep it (MarshalText / ParseInteractionRequest, where only the app can write) and why a modified copy can't widen a grant. - server/doc.go lists LookupBackchannelInteraction with the other CIBA methods. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Docs checked against v0.41.0 with the same four mechanical checks as the previous sweep (#405), rather than by reading prose:
pkg.Identifierin Markdown and Go doc comments resolved against the packages' exported API. Clean; the only hits were method shorthand (client.ExchangeCodefor(*Client).ExchangeCode) and local variables in code comments.serverresource.NewVerifierwere then run with real values and succeeded as written.invalid_dpop_proof, required redirect URIs, CIBA ping and session handling, interaction state, conformance leg counts). None stale.Fixes
conformance/server/oidf-config/README.md's heading "Client Credentials Grant ({baseline,…}-client-credentials.config.json)" gave GitHub an anchor with the file names in it, so both links to#client-credentials-grant(fromconformance/README.mdand within the file) went nowhere. The heading is now just "Client Credentials Grant", with the config names on the section's first line.a.Handlemust come back toCompleteAuthorizationbut not how the consent submission getsa.Interactionback. New paragraph: encode it withMarshalText, keep it with the handle where only the application can write it (server-side session or signed cookie), and restore it withserver.ParseInteractionRequest. It also explains why a modified copy can't widen the grant, and points to the federated-union demo.server/doc.go: the overview's method list now includesLookupBackchannelInteraction.🤖 Generated with Claude Code