Skip to content

fix: Allow non-Facebook copyright in pre-commit license-header check#1845

Open
yingsu00 wants to merge 23 commits into
IBM:mainfrom
yingsu00:license
Open

fix: Allow non-Facebook copyright in pre-commit license-header check#1845
yingsu00 wants to merge 23 commits into
IBM:mainfrom
yingsu00:license

Conversation

@yingsu00

Copy link
Copy Markdown
Collaborator

Update license-header.py to accept any Apache 2.0 license header regardless of copyright holder. Files with an IBM Corporation (or other non-Facebook) copyright are recognized as valid and left untouched.

Update license.header to use IBM Corporation as the default copyright for new files added in this fork.

@yingsu00 yingsu00 requested a review from ethanyzhang March 25, 2026 09:14
@yingsu00 yingsu00 requested a review from majetideepak as a code owner March 25, 2026 09:14
@yingsu00 yingsu00 removed the request for review from majetideepak March 25, 2026 09:14
@ethanyzhang

Copy link
Copy Markdown
Collaborator

If you guys are ok with this then just alchemy link it

@prestodb-ci prestodb-ci force-pushed the main branch 8 times, most recently from ce78850 to b40c4c8 Compare April 2, 2026 17:02
@prestodb-ci prestodb-ci force-pushed the main branch 7 times, most recently from a63cfe4 to f230429 Compare April 13, 2026 06:50
@prestodb-ci prestodb-ci force-pushed the main branch 4 times, most recently from 55ad294 to 63c6274 Compare April 21, 2026 11:35
@prestodb-ci prestodb-ci force-pushed the main branch 7 times, most recently from fe94045 to e52cda7 Compare April 26, 2026 21:25
@prestodb-ci prestodb-ci force-pushed the main branch 5 times, most recently from 9664ea4 to 16c923a Compare June 4, 2026 00:57
rui-mo and others added 23 commits June 5, 2026 21:29
Alchemy-item: (ID = 1565) [OAP] Support struct schema evolution matching by name commit 1/1 - 5bf50ef
…ter join

Signed-off-by: Yuan <yuanzhou@apache.org>

Alchemy-item: (ID = 1227) [OAP] [11771] Fix smj result mismatch issue commit 1/1 - 987fd37
Alchemy-item: (ID = 1309) feat: Enable the hash join to accept a pre-built hash table for joining commit 1/1 - b1a8bb4
Alchemy-item: (ID = 1294) feat: Change SpillPartitionId::kMaxSpillLevel to 7 commit 1/1 - 7280b67
Signed-off-by: Yuan <yuanzhou@apache.org>
Signed-off-by: Mohammad Linjawi <linjawi.mohammad@gmail.com>
(cherry picked from commit 4cd49ab)
(cherry picked from commit 4fc58be)

Alchemy-item: (ID = 1537) [OAP] fix to use spliter iceberg reader commit 1/1 - 064cc0e
Co-authored-by: Li Zhou <unidevel@hotmail.com>
Co-authored-by: mohsaka <135669458+mohsaka@users.noreply.github.com>

Alchemy-item: (ID = 1567) Iceberg core code commit 1/2 - 3376ba0
Alchemy-item: (ID = 1567) Iceberg core code commit 2/2 - 046a1db
Signed-off-by: Yuan <yuanzhou@apache.org>

Alchemy-item: (ID = 906) fix: Adding daily tests commit 1/2 - e2eb2c6
we can cache ccache on every build even on failure, since ibm/velox is
always incremental build

Alchemy-item: (ID = 906) fix: Adding daily tests commit 2/2 - 0899ddc
1
Alchemy-item: (ID = 988) Add fileNameGenerator to the constructor of IcebergInsertTableHandle commit 1/1 - a5f7e46
This commit introduces `PartitionedVector` - a low-level execution
abstraction that provides an in-place, partition-aware layout of a
vector based on per-row partition IDs.

1. **In-place rearrangement**: Rearrange vector data in memory without
   creating multiple copies
2. **Buffer reuse**: Allow reuse of temporary buffers across multiple
   partitioning operations
3. **Minimal abstraction**: Similar to `DecodedVector`, focus on
   efficient execution rather than operator semantics
4. **Thread-unsafe by design**: Optimized for single-threaded execution
   contexts

For more information please see IBM#1703

Alchemy-item: (ID = 1150) Introducing PartitionedVector commit 1/1 - 960f41b

Alchemy-item: (ID = 1327) Optimized PartitionedOutput staging hub commit 1/11 - 76dc41a
Signed-off-by: Xin Zhang <xin-zhang2@ibm.com>

Alchemy-item: (ID = 1167) Add PartitionedRowVector commit 1/1 - f2af427

Alchemy-item: (ID = 1327) Optimized PartitionedOutput staging hub commit 2/11 - 3853bf6
…dthValuesInPlace

Alchemy-item: (ID = 1327) Optimized PartitionedOutput staging hub commit 3/11 - ff2e34b
Alchemy-item: (ID = 1327) Optimized PartitionedOutput staging hub commit 4/11 - 875c92c
PartitionedFlatVector::partition() and PartitionedRowVector::partition()
called mutableRawNulls() unconditionally. mutableRawNulls() allocates a
null buffer if one does not exist, causing mayHaveNulls() to return true
for every vector after partitioning, even when the original had no nulls.

Fix both sites to check rawNulls() first and only call mutableRawNulls()
when a null buffer already exists.

Add noNullBufferAllocatedForNullFreeFlat and
noNullBufferAllocatedForNullFreeRow tests to PartitionedVectorTest to
cover this case.

# Conflicts:
#	velox/vector/PartitionedVector.cpp

Alchemy-item: (ID = 1327) Optimized PartitionedOutput staging hub commit 5/11 - 281a365
Alchemy-item: (ID = 1327) Optimized PartitionedOutput staging hub commit 6/11 - 6519a8f
Alchemy-item: (ID = 1327) Optimized PartitionedOutput staging hub commit 7/11 - d8f34b4
Alchemy-item: (ID = 1327) Optimized PartitionedOutput staging hub commit 8/11 - 9eafc9d
This commit introduces PrestoIterativePartitioningSerializer, which
buffers RowVectors across multiple append() calls, partitions rows
in-place using PartitionedVector, and on flush() serializes each
non-empty partition into a Presto wire-format IOBuf. The serializer has
no dependency on velox_exec: it returns raw folly::IOBuf objects,
leaving SerializedPage creation to the caller.

Alchemy-item: (ID = 1327) Optimized PartitionedOutput staging hub commit 9/11 - 6f09ea9
This commit introduces OptimizedPartitionedOutput, a PartitionedOutput
operator backed by PrestoIterativePartitioningSerializer. Enabled via query
config key "optimized_repartitioning" (default off). LocalPlanner
selects it over the standard PartitionedOutput when the flag is set.

TODO: replicateNullsAndAny is not yet supported and raises a user error.

Alchemy-item: (ID = 1327) Optimized PartitionedOutput staging hub commit 10/11 - c114147
…geBenchmark

- Added normal vs optimized PartitionedOutput comparison by running each
  exchange case twice with kOptimizedPartitionedOutputEnabled=false/true.
- Added per-mode benchmark names:
  - exchange<Case>_normalPartitionedOutput
  - exchange<Case>_optimizedPartitionedOutput in ExchangeBenchmark.cpp.
- Refactored result printing into shared helpers and fixed output
  consistency in ExchangeBenchmark.cpp.

Alchemy-item: (ID = 1327) Optimized PartitionedOutput staging hub commit 11/11 - 211901c
Signed-off-by: Hazmi <ialhazmim@gmail.com>

Alchemy-item: (ID = 1203) Fix iceberg min max statistics for decimal type when encoded as int32 commit 1/1 - 0ac9930
Update license-header.py to accept any Apache 2.0 license header
regardless of copyright holder. Files with an IBM Corporation (or other
non-Facebook) copyright are recognized as valid and left untouched.

Update license.header to use IBM Corporation as the default copyright
for new files added in this fork.
@yingsu00

yingsu00 commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator Author

alchemy link 699f4b8

@prestodb-ci

Copy link
Copy Markdown
Collaborator

alchemy link can only be used by contributors or admins.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.