Skip to content

Optimized PartitionedOutput staging hub#1799

Open
yingsu00 wants to merge 11 commits into
staging/staging-rebase-optimized_partitionedoutputfrom
optimized_partitionedoutput
Open

Optimized PartitionedOutput staging hub#1799
yingsu00 wants to merge 11 commits into
staging/staging-rebase-optimized_partitionedoutputfrom
optimized_partitionedoutput

Conversation

@yingsu00

@yingsu00 yingsu00 commented Mar 11, 2026

Copy link
Copy Markdown
Collaborator

This PR is to track the commits for the optimized PartitionedOutput operator. Related new PRs shall be submitted to optimized_partitionedoutput branch, and then alchemy merge to oss-main.

Review history of the first two commits can be found in
feat: Introducing PartitionedVector #1596
feat: Add PartitionedRowVector implementation #1770

@yingsu00 yingsu00 requested a review from majetideepak as a code owner March 11, 2026 14:56
@yingsu00 yingsu00 removed the request for review from majetideepak March 11, 2026 14:56
@yingsu00

Copy link
Copy Markdown
Collaborator Author

alchemy link 86db93b

@prestodb-ci

Copy link
Copy Markdown
Collaborator

Added new rebase item:

@yingsu00

Copy link
Copy Markdown
Collaborator Author

alchemy link 6dd3661

@prestodb-ci

Copy link
Copy Markdown
Collaborator

The following unexpired item was removed at 2026-03-10T12:01:55Z by @yingsu00 via #1799 (comment):

Added new rebase item:

@yingsu00

Copy link
Copy Markdown
Collaborator Author

alchemy link 2706c1e

@prestodb-ci

Copy link
Copy Markdown
Collaborator

The following unexpired item was removed at 2026-03-12T13:19:10Z by @yingsu00 via #1799 (comment):

Added new rebase item:

@unidevel

Copy link
Copy Markdown
Collaborator

alchemy link 86db93b,6dd3661c7afef52c42ed1c5ca83c9e57e21ec2b3,2706c1e80f9463bd4fdd805e296839f964437ca3

@prestodb-ci

Copy link
Copy Markdown
Collaborator

Failed to add new rebase item:

The new rebase item overlaps with the following existing item:

Please double check your input and retry.

@unidevel

Copy link
Copy Markdown
Collaborator

alchemy link 86db93b,6dd3661c7afef52c42ed1c5ca83c9e57e21ec2b3,2706c1e80f9463bd4fdd805e296839f964437ca3 @2026-03-10T12:01:55Z

@prestodb-ci

Copy link
Copy Markdown
Collaborator

Failed to add new rebase item:

The new rebase item overlaps with the following existing item:

Please double check your input and retry.

@unidevel

Copy link
Copy Markdown
Collaborator

alchemy link 86db93b,6dd3661c7afef52c42ed1c5ca83c9e57e21ec2b3,2706c1e80f9463bd4fdd805e296839f964437ca3 @2026-03-12T13:19:10Z

@prestodb-ci

Copy link
Copy Markdown
Collaborator

The following unexpired item was removed at 2026-03-12T13:19:10Z by @unidevel via #1799 (comment):

Added new rebase item:

@prestodb-ci

Copy link
Copy Markdown
Collaborator

Failed to cherry-pick commit 546d0bd in rebase request #2189:

exit status 1
error: could not apply 546d0bdf1... feat(PartitionedOutput): Add OptimizedPartitionedOutput operator

Auto-merging velox/core/QueryConfig.h
CONFLICT (content): Merge conflict in velox/core/QueryConfig.h
Auto-merging velox/exec/CMakeLists.txt
Auto-merging velox/exec/LocalPlanner.cpp

Please:

  1. Rebase your branch with staging/staging-rebase and fix the conflict. If the rebase item is a PR, you can change the base branch to this staging branch.

  2. Comment on this issue with the updated rebase item.

    For a PR (copy and edit):

    alchemy merge @2026-06-25T18:39:48Z
    

    For an issue (copy and edit):

    alchemy link [updated comma-separated commit SHAs for this issue] @2026-06-25T18:39:48Z
    
  3. Re-open Rebase branch staging-rebase (a4c9d0c) with staging-rebase-head (1a4d124) #2189 to retry the cherry-pick.

yingsu00 added 2 commits June 25, 2026 21:20
This commit introduces OptimizedPartitionedOutput, a PartitionedOutput
operator backed by PrestoIterativePartitioningSerializer. Enabled via query
config key "optimized_repartitioning" (default off). LocalPlanner
selects it over the standard PartitionedOutput when the flag is set.

TODO: replicateNullsAndAny is not yet supported and raises a user error.
…geBenchmark

- Added normal vs optimized PartitionedOutput comparison by running each
  exchange case twice with kOptimizedPartitionedOutputEnabled=false/true.
- Added per-mode benchmark names:
  - exchange<Case>_normalPartitionedOutput
  - exchange<Case>_optimizedPartitionedOutput in ExchangeBenchmark.cpp.
- Refactored result printing into shared helpers and fixed output
  consistency in ExchangeBenchmark.cpp.
@xin-zhang2 xin-zhang2 force-pushed the optimized_partitionedoutput branch from 974bb09 to ee25fa7 Compare June 25, 2026 20:22
@github-actions github-actions Bot added the cudf label Jun 25, 2026
@xin-zhang2 xin-zhang2 changed the base branch from staging/staging-rebase-20260611231810 to staging/staging-rebase-optimized_partitionedoutput June 25, 2026 20:23
@xin-zhang2 xin-zhang2 removed the cudf label Jun 25, 2026
@xin-zhang2

Copy link
Copy Markdown
Member

alchemy merge @2026-06-25T18:39:48Z

@prestodb-ci

Copy link
Copy Markdown
Collaborator

alchemy link 23e8d1d,7df0be41dac449670584be5336587a1d3df135bf,5719f909a173ce08e483b900b6a2811da82e112b,fad80645718f89d4b3598859c2b51c2ebfd9e43e,04fbad0a3b5d14d5dc890ae4e05cf35f715ae194,c3a52c9e9b46e6c6abb3d40b7f978bfac833d9eb,9efe82a5fb4e13a348573cb4d4f893541cea47d0,ff888e7bd593f0a909bc75b0b7213b3200e968b1,1511c01f8c5e7b36c77f52a0c8a7a558d3c99676,e567d50501a13f650c8d25cc18d045379631b1dc,ee25fa7738c87a1da498e4ff679cd2fa8abd8684 @2026-06-25T18:39:48Z

@prestodb-ci

Copy link
Copy Markdown
Collaborator

The following unexpired item was removed at 2026-06-25T18:39:48Z by @prestodb-ci via #1799 (comment):

Added new rebase item:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants