Add an "emissions diagnostics" processor#3
Merged
Conversation
Contributor
|
I don't really have the domain knowledge to comment on whether what the processor is doing makes sense, but on the code/design side, I'd say, it would be good to have docstrings for the methods/functions, and if there are any variables/regions that are mandatory for processing to work, then to add some Pydantic validator to check that. |
phackstock
reviewed
Apr 9, 2026
phackstock
left a comment
There was a problem hiding this comment.
Looks good to me in principle a few small comments and suggestions in line below.
Member
Author
|
Thanks for the review comments - I added tests to make sure that either an error is raised when the wrong units are used or that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR transfers the script for the Scenario Compass to compute emissions-diagnostics indicators and implements it as a nomenclature Processor subclass.
The idea is that this can be imported in a workflow as
and then either in a longer processing workflow simply calling
or as a stand-alone (atomic) workflow like
and then write only
emissions_diagnostics.output_metaback to theplatform.Any thoughts about the design?